[improve][broker] Add error logs and retry if the broker failed to register itself for metadata node deletion #23390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elf for metadata node deletion
BewareMyPower
added
type/enhancement
BewareMyPower
requested review from
lhotari,
codelipenghui,
mattisonchao and
heesung-sn
BewareMyPower
changed the title
|
This change conflicts with this one, #23382. I also added a retry logic in this PR, and I think we need to run the listeners after registering the lock. Otherwise, there can be a racing condition between orphan bundle cleanup and the lock recreation. |
|
Let's close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In my chaos test environment, I found some
registerAsynccall failed. However, there is no error log for it.Modifications
Add the error logs for failure of
registerAsyncand retry inhandleMetadataStoreNotification. ForBrokerRegistryImpl#start, the error info is wrapped into thePulsarServerExceptionpropagated to thePulsarService#start's catch block and it will fail fast so we don't need to log errors here.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: