Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix DeadLetterTopicTest.testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers #23552

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ZhaoGuorui666
Copy link
Contributor

Fixes #23542

Motivation

The original receiverQueueSize was 100, and the producer generated a total of 100 messages. It is possible that all messages were put into the dead letter queue by one consumer, resulting in assertion failure.

Modifications

Reduce the size of the receiverQueueSize to ensure that every consumer processes the message.

receiverQueueSize :100 -> 20

Verifying this change

image

The last test was manually cancelled.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 4, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (bbc6224) to head (e7dfcbf).
Report is 716 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23552      +/-   ##
============================================
+ Coverage     73.57%   74.27%   +0.70%     
- Complexity    32624    34316    +1692     
============================================
  Files          1877     1943      +66     
  Lines        139502   147050    +7548     
  Branches      15299    16209     +910     
============================================
+ Hits         102638   109223    +6585     
- Misses        28908    29386     +478     
- Partials       7956     8441     +485     
Flag Coverage Δ
inttests 27.31% <ø> (+2.73%) ⬆️
systests 24.35% <ø> (+0.03%) ⬆️
unittests 73.65% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 649 files with indirect coverage changes

@Technoboy- Technoboy- added this to the 4.1.0 milestone Nov 6, 2024
@Technoboy- Technoboy- merged commit c266db2 into apache:master Nov 6, 2024
53 checks passed
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…scriptionAndMultiConsumers (#23552)

(cherry picked from commit c266db2)
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…scriptionAndMultiConsumers (#23552)

(cherry picked from commit c266db2)
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…scriptionAndMultiConsumers (#23552)

(cherry picked from commit c266db2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: DeadLetterTopicTest.testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers
4 participants