-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][admin] Print error log if handle http response fails #23563
[improve][admin] Print error log if handle http response fails #23563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23563 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
- Complexity 32624 34327 +1703
============================================
Files 1877 1943 +66
Lines 139502 147056 +7554
Branches 15299 16210 +911
============================================
+ Hits 102638 109310 +6672
- Misses 28908 29327 +419
- Partials 7956 8419 +463
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit c15a0d6)
(cherry picked from commit c15a0d6)
(cherry picked from commit c15a0d6)
Motivation
When users are calling
pulsar-admin
API, and there is an internal error( such as a deserialize JSON error), there is no error log.You can test it this way:
TopicStatsImpl
, and return aString
value(such asabc
), which will make theresponse.msgRateIn
as a String valueabc
.pulsar-admin topics stats
Modifications
Print error log if handle HTTP response fails
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x