Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practice for unit and integration tests for Pulsar #23565

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practice for unit and integration tests for Pulsar #23565

wants to merge 2 commits into from
+79 −0

Conversation

heesung-sn
Copy link
Contributor

This is a PIP

@heesung-sn
[improve][pip] Improve the reusability of Pulsar integration test cod…
51ce24b 
…e and best practices for unit and integration tests in Pulsar
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

@heesung-sn Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@heesung-sn heesung-sn changed the title [improve][pip] Improve the reusability of Pulsar integration test code and best practices for unit and integration tests in Pulsar [improve][pip] PIP-390 Improve the reusability of Pulsar integration test code and best practices for unit and integration tests in Pulsar Nov 5, 2024
@heesung-sn heesung-sn changed the title [improve][pip] PIP-390 Improve the reusability of Pulsar integration test code and best practices for unit and integration tests in Pulsar [improve][pip] PIP-390 Improve the reusability of Pulsar integration test code and best practices for unit and integration tests for Pulsar Nov 5, 2024
@heesung-sn heesung-sn changed the title [improve][pip] PIP-390 Improve the reusability of Pulsar integration test code and best practices for unit and integration tests for Pulsar [improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practices for unit and integration tests for Pulsar Nov 12, 2024
@heesung-sn heesung-sn changed the title [improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practices for unit and integration tests for Pulsar [improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practice for unit and integration tests for Pulsar Nov 12, 2024
zzzk1
zzzk1 reviewed Nov 16, 2024
View reviewed changes
pip/pip-390.md

- Pulsar integration tests are located in the `tests` module, which run on [testcontainers](https://github.com/testcontainers).
- Pulsar unit tests are located in each module under the test scope, with many tests running on mocked (in-memory) Pulsar clusters.
- Currently, Pulsar tests run on the `testng` framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Currently, Pulsar tests run on the `testng` framework.
- Currently, Pulsar tests run on the [TestNG](https://testng.org/#_welcome_to_testng).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that directly providing the framework link may be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzk1 zzzk1 zzzk1 left review comments

@lhotari lhotari Awaiting requested review from lhotari

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc-label-missing PIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heesung-sn @zzzk1