[improve][consumer] Optimizing Exception Handling and Logging in MultiTopicsConsumerImpl
#23568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
reviewed
Nov 7, 2024
| @@ -383,6 +383,12 @@ protected Message<T> internalReceive() throws PulsarClientException { | |||
| unAckedMessageTracker.add(message.getMessageId(), message.getRedeliveryCount()); | |||
| resumeReceivingFromPausedConsumersIfNeeded(); | |||
| return beforeConsume(message); | |||
| } catch (IllegalArgumentException e) { | |||
There was a problem hiding this comment.
It looks checkState(message instanceof TopicMessageImpl); will throw this exception.
When will this happen? Could you shared your case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Generic Exception Handling:
internalReceivemethod currently catches all exceptions, which can obscure the root cause of specific failures, such as invalid message types.Insufficient Logging for Validation Failures:
Preconditions.checkArgumentfails (throwing anIllegalArgumentException), the existing implementation does not log detailed information about the failure. This limitation makes it challenging to diagnose issues related to message type mismatches.Modifications
catchblock forIllegalArgumentExceptionto log detailed information before rethrowing as aPulsarClientException.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete