Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip for role anonymizer #23592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KannarFr
Copy link
Contributor

PIP for #23386

Copy link

@KannarFr Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@@ -0,0 +1,120 @@
# PIP-385: Role Anonymizer for Pulsar Logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIP-385 is already taken.

Please find another available PIP. The current way to find an available PIP is to search on the dev mailing list discussions whether there's a conflict with the picked PIP number. The first one to open the discussion about the PIP "wins".

You should also make the PR title match the way that we use
[feat][pip] PIP-XXX: Role Anonymizer for Pulsar Logging would be the way to name the PR. Start the thread on the dev mailing list asap after assigning the PR number so that you "win" the possible race condition in assigning the PIP number.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the current moment, PIP-393 is the next available PIP number.
Here's the search: https://lists.apache.org/[email protected]:lte=1y:PIP-393

I first looked at https://lists.apache.org/[email protected] and then started incrementing the PIP number until there were no search matches. That's how you find an available PIP number.

You could also check if someone has already created a PR with PIP-393 with this query "is:pr in:title PIP-393"
https://github.com/apache/pulsar/pulls?q=is%3Apr+in%3Atitle+PIP-393

That's the reason also why you should follow the current conventions for starting the thread and for naming the PR for the PIP. We should include the proper steps in the PIP README so that it's clear to everyone how the PIP number gets assigned in practice.

Here's a good example of how to start the discussion thread: https://lists.apache.org/thread/9wddmj4o5mrdst427r40rr7phqb05y6s
And after the discussion, starting the voting thread:
https://lists.apache.org/thread/p4zvok4l6dxrm0hqbno5s21tq4s33f7s
There will soon be an example of closing the voting thread there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants