Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] No longer allow creating subscription that contains slash #23594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poorbarcode
Copy link
Contributor

Motivation

Topic name rule

  • old version: {tenant}/{cluster}/{namespace}/{topic}/{subscription}
  • new version: {tenant}/{namespace}/{topic}/{subscription}

There are many HTTP APIs defined as HTTP Method {topic name}/{subscription name}

If a subscription contains /, the broker will assume it is a topic created with the old rule, then users will get a cluster does not exist error or a topic not found error

Modifications

No longer allow creating a subscription that contains a slash

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug release/3.3.3 release/3.0.8 release/4.0.1 labels Nov 12, 2024
@poorbarcode poorbarcode added this to the 4.1.0 milestone Nov 12, 2024
@poorbarcode poorbarcode self-assigned this Nov 12, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 12, 2024
@Technoboy- Technoboy- closed this Nov 12, 2024
@Technoboy- Technoboy- reopened this Nov 12, 2024
@gaoran10
Copy link
Contributor

gaoran10 commented Nov 13, 2024

LGTM.

Do we need to support decoding URL-encoded subscription names in broker side? Thus users can use existing URL-encoded subscription names in HTTP requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.8 release/3.3.3 release/4.0.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants