PROTON-2792: [C++] check that scheduled tasks are active under lock #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we checked whether the tasks were active without locking which was bad.
|
Yes, this fixes the issue while preserving the semantics, thank you. |
|
+1 |
Test for cancelling tasks from previous task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked whether the tasks were active without locking which was bad.
This is is an alternative fix (which has the correct semantics) to #421.
I think it probably still needs a test for the fixed behaviour and the correct semantics before merging. This would be new tests in
container_test.cpp