[Improve][Connector-file-base] In large file scenarios, split the single file into multiple shards #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corgy-w
reviewed
Jan 13, 2025
| reader.getNumberOfRows()); | ||
| long rowCountPerSplit = rowCountPerSplitByUser; | ||
| if (rowCountPerSplit <= 0) { | ||
| // 按照文件大小自动分片 |
There was a problem hiding this comment.
Comments similar to Chinese can be changed to English, some of them can check for themselves
liunaijie
reviewed
Jan 14, 2025
| * @return FileSourceSplit set | ||
| */ | ||
| @Override | ||
| public Set<FileSourceSplit> getFileSourceSplits(String path) { |
There was a problem hiding this comment.
Hi, thanks for this great work, as you write when enable this it can mark data out of order, so can we enable this feature when user config file_size_per_split/row_count_per_split parameters? if not set, still use the original method. we can describe this feature in document.
And when use this feaute we need the file format can be quick seek to the specified offset, like rows.seekToRow method.
Now we has other file format support, like parquet, avro etc, can you help update other file format too, thanks.
There was a problem hiding this comment.
ok.
- i will add an option to control whether to enable the feature.
- I think the text format file may not be too large. I will see how to add it later.
Hisoka-X
reviewed
Jan 15, 2025
...main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfigOptions.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public void read(FileSourceSplit split, Collector<SeaTunnelRow> output) |
There was a problem hiding this comment.
It would be best to do some refactoring, I found that the new read method has a lot in common with the old read method.
| * In theory, batch column reading can improve reading performance. | ||
| */ | ||
| @Override | ||
| public void read(FileSourceSplit split, Collector<SeaTunnelRow> output) |
… big file read scene.
… for big file read scene.
…gle file into multiple shards
…gle file into multiple shards
…gle file into multiple shards
…/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfigOptions.java Co-authored-by: Jia Fan <[email protected]>
…/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java Co-authored-by: Jia Fan <[email protected]>
…/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/OrcReadStrategy.java Co-authored-by: Jia Fan <[email protected]>
…gle file into multiple shards
…gle file into multiple shards
github-actions
bot
added
document
core
sohurdc
force-pushed
the
orc_bigfile_split_read
branch
from
9d61d4c to
71e9c36
Compare
github-actions
bot
removed
document
core
added 4 commits
January 23, 2025 16:58
…gle file into multiple shards
…gle file into multiple shards
…gle file into multiple shards
…gle file into multiple shards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large file scenarios, split the single file into multiple shards
Purpose of this pull request
split a single orc file into multi splits. now only support orc fileformat, parquet will be added soon.
Does this PR introduce any user-facing change?
yes, but user can use default options now
How was this patch tested?
i have added test case
Check list
New License Guide
release-note.