Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improve Makefile by Using requirements-docs.txt for Documentation Dependencies #1808

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

BaseMax
Copy link
Contributor

@BaseMax BaseMax commented Feb 12, 2025

This update refactors the docsinstall target in the Makefile to use a predefined requirements-docs.txt file instead of dynamically creating it. This ensures better dependency management, simplifies maintenance, and aligns with best practices for handling Python package installations.

@BaseMax BaseMax requested a review from jiayuasu as a code owner February 12, 2025 20:18
@github-actions github-actions bot added the root label Feb 12, 2025
@jbampton jbampton self-assigned this Feb 12, 2025
@jbampton jbampton added improvement python Pull requests that update Python code labels Feb 12, 2025
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Ran the Makefile phony targets. Seems to work.

Thanks 👍

@jiayuasu jiayuasu changed the title Improve Makefile by Using requirements-docs.txt for Documentation Dependencies [DOCS] Improve Makefile by Using requirements-docs.txt for Documentation Dependencies Feb 12, 2025
@jiayuasu jiayuasu merged commit ea4ca69 into apache:master Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement python Pull requests that update Python code root
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants