Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2805]change default settings for http keepalive timeout and idle… #3927

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

liubao68
Copy link
Contributor

… timeout

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3927 (c77bc13) into 2.8.x (7099475) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c77bc13 differs from pull request most recent head c7635c4. Consider uploading reports for the commit c7635c4 to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3927      +/-   ##
============================================
+ Coverage     74.43%   74.45%   +0.01%     
  Complexity      690      690              
============================================
  Files          1592     1592              
  Lines         39985    39983       -2     
  Branches       3648     3644       -4     
============================================
+ Hits          29764    29768       +4     
+ Misses         8734     8729       -5     
+ Partials       1487     1486       -1     
Files Changed Coverage Δ
...dation/vertx/client/http/HttpClientOptionsSPI.java 72.41% <100.00%> (+2.04%) ⬆️
...b/transport/rest/client/TransportClientConfig.java 100.00% <100.00%> (+13.33%) ⬆️
...ecomb/transport/rest/vertx/RestServerVerticle.java 61.84% <100.00%> (+1.29%) ⬆️
...vicecomb/transport/rest/vertx/TransportConfig.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants