Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2806]disable OperationInstancesDiscoveryFilter by defalut #3930

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3930 (a031a64) into 2.8.x (fd35498) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a031a64 differs from pull request most recent head f9cbe57. Consider uploading reports for the commit f9cbe57 to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3930      +/-   ##
============================================
- Coverage     74.45%   74.45%   -0.01%     
  Complexity      690      690              
============================================
  Files          1592     1592              
  Lines         39991    39991              
  Branches       3645     3645              
============================================
- Hits          29777    29775       -2     
- Misses         8731     8733       +2     
  Partials       1483     1483              
Files Changed Coverage Δ
...y/discovery/OperationInstancesDiscoveryFilter.java 90.90% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 49da1b6 into apache:2.8.x Aug 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants