Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2807]add missed test case #3934

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Sep 1, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3934 (7dd1893) into 2.8.x (71b0003) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 7dd1893 differs from pull request most recent head 3bab093. Consider uploading reports for the commit 3bab093 to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3934      +/-   ##
============================================
- Coverage     74.39%   74.17%   -0.22%     
- Complexity      690      703      +13     
============================================
  Files          1592     1597       +5     
  Lines         39991    40164     +173     
  Branches       3645     3663      +18     
============================================
+ Hits          29752    29793      +41     
- Misses         8759     8888     +129     
- Partials       1480     1483       +3     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 8d1d911 into apache:2.8.x Sep 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants