Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3977]fix logs information not clear problem #3999

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #3999 (41e05de) into 2.8.x (4f59e71) will increase coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head 41e05de differs from pull request most recent head 60b72df. Consider uploading reports for the commit 60b72df to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3999      +/-   ##
============================================
+ Coverage     74.23%   74.24%   +0.01%     
  Complexity      703      703              
============================================
  Files          1597     1597              
  Lines         40170    40176       +6     
  Branches       3669     3669              
============================================
+ Hits          29820    29830      +10     
+ Misses         8861     8860       -1     
+ Partials       1489     1486       -3     
Files Coverage Δ
...in/java/org/apache/servicecomb/core/SCBEngine.java 78.96% <100.00%> (+0.08%) ⬆️
...r/governance/InstanceIsolationDiscoveryFilter.java 79.59% <100.00%> (+1.33%) ⬆️
.../servicecomb/foundation/vertx/VertxTLSBuilder.java 64.63% <33.33%> (-1.62%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 4ed65bf into apache:2.8.x Oct 30, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants