move zkRegCenter.init() and zkRegCenter.close() to @BeforeAll and @AfterAll to make tests run faster and look similar to other tests #2378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
zkRegCenter.init();
andzkRegCenter.close();
into the method body of@BeforeAll
and@AfterAll
. There are three tests in the test classOneOffJobBootstrapTest
. However, these three tests are justing trying to usezkRegCenter
to initialize some objects and they are not modifyingzkRegCenter
.zkRegCenter.init();
andzkRegCenter.close();
. All tests in the projectapache/shardingsphere-elasticjob
exceptOneOffJobBootstrapTest
putzkRegCenter.init();
andzkRegCenter.close();
into the method body of@BeforeAll
and@AfterAll
.3.489 s
to2.403 s
after applying the changes when run on our machine.