Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding setup.kind.no-wait configuration #127

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Jul 3, 2024

Currently, I am trying to use the E2E tool for simulating a cilium cluster (based on kind), but since cilium requires to use them self CNI, so all kind resources will not be deployed (in padding state) until cilium is installed. Therefore the wait in the setup stage has no meaning.

To fix this issue, I added a no-wait field with default value as false, it still continues to wait unless specified manually as true in the configuration. Thus it won't affect existing E2E workflow.

@mrproliu mrproliu added the enhancement New feature or request label Jul 3, 2024
@mrproliu mrproliu added this to the 1.4.0 milestone Jul 3, 2024
@mrproliu mrproliu requested a review from kezhenxu94 July 3, 2024 14:29
@mrproliu mrproliu merged commit 7f6b0da into apache:main Jul 4, 2024
2 checks passed
@mrproliu mrproliu deleted the kind-no-wait branch July 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants