Fix TestClient for fastapi cause the req.client None error (#355)

apache · Nov 6, 2024 · 55dc5ff · 55dc5ff
1 parent ff1f6a2
commit 55dc5ff
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,16 @@
 ## Change Logs
 
+### 1.2.0
+
+- Feature:
+  - Drop support for 3.7 (#356)
+
+- Fixes:
+  - Fix: user/password replacement is not allowed for relative URLs (#349)
+  - Fix pulsar client does not support init arguments other than service_url (#351)
+  - Fix outdated make dev-fix rule in CodeStyle.md (#350)
+  - Fix TestClient for fastapi cause the req.client None error (#355)
+
 ### 1.1.0
 
 - Feature:

diff --git a/skywalking/plugins/sw_fastapi.py b/skywalking/plugins/sw_fastapi.py
@@ -56,7 +56,7 @@ async def create_span(self, method, scope, req, send, receive):
         with span:
             span.layer = Layer.Http
             span.component = Component.FastAPI
-            span.peer = f'{req.client.host}:{req.client.port}'
+            span.peer = f'{req.client.host}:{req.client.port}' if req.client else 'unknown'
             span.tag(TagHttpMethod(method))
             span.tag(TagHttpURL(str(req.url).split('?')[0]))
             if config.plugin_fastapi_collect_http_params and req.query_params: