SOLR-16870: remove now dead lines of code

[epugh]

https://issues.apache.org/jira/browse/SOLR-16870

Description

Remove dead lines of code now that SolrCLI.java has a printHelp method.

Solution

Delete lines.

Tests

bats tests, but going to reach out to @Willdotwhite about verifying the Windows change!

Checklist

Please review the following and check all that apply:

• [X ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• [ X] I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
• [ x] I have developed this patch against the main branch.
• [ x] I have run ./gradlew check.
• [ n/a] I have added tests for my changes.
• [ n/a] I have added documentation for the Reference Guide

[Willdotwhite]

Not sure this is ready to go yet; either my testing is flawed (below), or we're not catching the new flags:

PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -help
-help is not a valid command!
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -usage
-usage is not a valid command!
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd -h    
-h is not a valid command!
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd --help
--help is not a valid command!
PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd /?    
/? is not a valid command!

---

Could someone confirm/deny please: should these new lines (here):

IF "%1"=="-help" goto run_solrcli
IF "%1"=="-usage" goto run_solrcli
IF "%1"=="-h" goto run_solrcli
IF "%1"=="--help" goto run_solrcli
IF "%1"=="/?" goto run_solrcli

should target the following commands:

.\solr.cmd -help
.\solr.cmd -usage
.\solr.cmd -h
.\solr.cmd --help

(And I have absolutely no idea what /? is all about)

If so, is there a roadmap item for adding aliases for those tasks somewhere else? Unless I've massively misunderstood this task, I think the SolrCLI need a tweak to SolrCLI::main to catch the new flags (which I'll open as a PR just in case).

[Willdotwhite]

Pull request mentioned - FYI @epugh: epugh#4

[epugh]

Will commit this tomorrow (Saturday) ;-).