Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16850: Notify a user if they run Healthcheck againsts a standalone mode Solr #1804

Merged
merged 5 commits into from
Jul 25, 2023
Merged

SOLR-16850: Notify a user if they run Healthcheck againsts a standalone mode Solr #1804

merged 5 commits into from
Jul 25, 2023

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Jul 22, 2023

https://issues.apache.org/jira/browse/SOLR-16850

Description

Alert a user, since you can use -solrUrl to point healthcheck at a standalone mode solr node.

Solution

No zkHost means not in SolrCloud mode!

Tests

Bats test.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh
Copy link
Contributor Author

epugh commented Jul 22, 2023

I think this is ready for feedback ;-)

@epugh epugh merged commit 34b3aef into apache:main Jul 25, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@epugh