Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17442: Resolve -v flag conflict (version, value, verbose) #2721

Merged
merged 17 commits into from
Sep 28, 2024
Merged

SOLR-17442: Resolve -v flag conflict (version, value, verbose) #2721

merged 17 commits into from
Sep 28, 2024

Commits on Sep 23, 2024

  1. add debug option and use it. solve bug where -h doesnt show globally … 

    …added options
    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6143378 View commit details
    Browse the repository at this point in the history

  2. first pass through of deprecating -v in favour -f -d

    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fd64e6f View commit details
    Browse the repository at this point in the history

  3. clarify that -v is for version, not for value. deprecate -v and encou… 

    …age --value
    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    323da9e View commit details
    Browse the repository at this point in the history

  4. if we are using -d then echoIfDebug follows the pattern.

    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3cc2a77 View commit details
    Browse the repository at this point in the history

  5. lint

    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0c9779d View commit details
    Browse the repository at this point in the history

  6. deprecate the -v and -V in favour --debug

    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    657b89f View commit details
    Browse the repository at this point in the history

  7. remove version as an actual tool. in the future if we want to probe s… 

    …olr maybe we have a "info" tool seperate from -v and --version. Tweak the help output
    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4cf5e7d View commit details
    Browse the repository at this point in the history

  8. check various places we do solr start and solr stop to make sure upda… 

    …ted docs
    @epugh
    epugh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    650a691 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. back out deprecation on what is not deprecated, at least in this PR

    @epugh
    epugh committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    02ff728 View commit details
    Browse the repository at this point in the history

  2. back out deprecation on what is not deprecated, at least in this PR

    @epugh
    epugh committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a8dfd23 View commit details
    Browse the repository at this point in the history

  3. remove references to -d and use --debug in places

    @epugh
    epugh committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5675a61 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Remove short form of --debug 

    Signed-off-by: Eric Pugh <[email protected]>
    @epugh
    epugh committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7779d19 View commit details
    Browse the repository at this point in the history

  2. Use OptionGroup to force either deprecated or non deprecated option

    @epugh
    epugh committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8a540e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Restore Verbose option

    @epugh
    epugh committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a313f1f View commit details
    Browse the repository at this point in the history

  2. lint

    @epugh
    epugh committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    fc0120d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into SOLR-17442

    @epugh
    epugh committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0003706 View commit details
    Browse the repository at this point in the history

  4. Track changes

    @epugh
    epugh committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    722e94e View commit details
    Browse the repository at this point in the history