Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17481: Resolve use of -n flag in CLI commands #2745

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Oct 7, 2024

https://issues.apache.org/jira/browse/SOLR-17481

Description

Deal with overlaps in flags

Solution

deprecate (9x) and remove (10.0) -n for defining the number of threads in SolrExporter
Remove -n for no-prompt in RunExampleTool (this option is not supported via bin/solr or bin/solr.cmd so no need to deprecate).

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@epugh
Copy link
Contributor Author

epugh commented Oct 7, 2024

@malliaridis this is ready for review. I just removed "n" from RunExampleTool since it is not exposed.

Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a PR so quickly. :)

Additional occurences that should be updated:

  • solr/solr-ref-guide/modules/deployment-guide/pages/monitoring-with-prometheus-and-grafana.adoc - ~6 occurences of -n for --num-threads
  • solr/dev-tools/scripts/cloud.sh - may be ignored, but uses -n for number of nodes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 7, 2024
@epugh
Copy link
Contributor Author

epugh commented Oct 7, 2024

Going to ignore cloud.sh since it doesn't have any long options... and I don't want to try to figure out adding long options!

Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then. :)

@epugh epugh changed the title SOLR-17481: Deprecate n for num-threads SOLR-17481: Resolve use of -n flag in CLI commands Oct 10, 2024
@epugh epugh merged commit a4cc580 into apache:main Oct 10, 2024
4 of 5 checks passed
epugh added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:cli documentation Improvements or additions to documentation prometheus-exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants