Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17480: Use --data-home everywhere #2747

Merged
merged 4 commits into from
Oct 8, 2024
Merged

SOLR-17480: Use --data-home everywhere #2747

merged 4 commits into from
Oct 8, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Oct 7, 2024

https://issues.apache.org/jira/browse/SOLR-17480

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot added documentation Improvements or additions to documentation start-scripts labels Oct 7, 2024
@epugh
Copy link
Contributor Author

epugh commented Oct 7, 2024

@malliaridis and ready!

Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update:

  • solr/bin/solr.cmd#310 - -t should be --data-home
  • solr/bin/solr.cmd#344 - -t should be --data-home
  • solr/bin/solr#370 - -t should be --data-home

@dsmiley
Copy link
Contributor

dsmiley commented Oct 7, 2024

Just a meta comment but it's annoying to read PR description that is our template that hasn't been filled out. Either fill it out or remove it. Always have the JIRA link though. Our PR template gives explicit permission for us to do so right after the JIRA link, but maybe should encourage us to.

Copy link
Contributor

@malliaridis malliaridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@epugh epugh merged commit f5b0129 into apache:main Oct 8, 2024
5 checks passed
epugh added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation start-scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants