SOLR-17494: Remove language specific writer types #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
gerlowskija
reviewed
Oct 13, 2024
| QueryResponseWriter w = new PythonResponseWriter(); | ||
| QueryResponseWriter w = new JSONResponseWriter(); | ||
| new StringWriter(); | ||
| StringWriter buf; |
There was a problem hiding this comment.
[-1] I think L60-L61 is a typo and should be the single line:
StringWriter buf = new StringWriter();
gerlowskija
reviewed
Oct 13, 2024
|
Thoughts on how to mark it "deprecated" in 9x? In some places it makes sense to put out a log message. What would being deprecated mean here? Just a PR that adds |
|
Deprecate as notice in ref guide. Also we have a separate deprecation logging mechanism. |
Cool.. So I will open a seperate PR that does those two things only in |
|
Can I get a LGTM and then I'll add CHANGES.txt and merge.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17494
Description
Language specific writers types are "evaled" which isn't secure. And not a pattern to be used.
Solution
Remove them from main.