-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17494: Document deprecation status of language specific writer types #2766
SOLR-17494: Document deprecation status of language specific writer types #2766
Conversation
Should we have a CHANGES.txt entry mentioning the deprecation? That looks like a popular place that deprecations are highlighted... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - pending a potential CHANGES.txt entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd mention the deprecation in Major Changes in Solr 9 page as well, under 9.8 header, as that's where we point people who upgrade. And add it in 10.0 section on main branch, but that can be done in the PR that actually deletes them.
=== Deprecations | ||
* The language specific Response Writers have been deprecated in favour of more widely used formats like JSON. | ||
The writer types invoked as part of the `wt` parameter that will be removed in 10 include `python`, `ruby`, `php`, and `phps`. | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you sneak in?
https://issues.apache.org/jira/browse/SOLR-17494
Description
Let users of 9x know that language specific writer types are deprecated and removed in 10
Solution
Java deprecation message and ref guide