Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17494: Document deprecation status of language specific writer types #2766

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Oct 15, 2024

https://issues.apache.org/jira/browse/SOLR-17494

Description

Let users of 9x know that language specific writer types are deprecated and removed in 10

Solution

Java deprecation message and ref guide

@epugh epugh changed the title SOLR-17494: Document deprecation status SOLR-17494: Document deprecation status of language specfic writer types Oct 15, 2024
@epugh epugh changed the title SOLR-17494: Document deprecation status of language specfic writer types SOLR-17494: Document deprecation status of language specific writer types Oct 15, 2024
@gerlowskija
Copy link
Contributor

Should we have a CHANGES.txt entry mentioning the deprecation? That looks like a popular place that deprecations are highlighted...

Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending a potential CHANGES.txt entry

Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mention the deprecation in Major Changes in Solr 9 page as well, under 9.8 header, as that's where we point people who upgrade. And add it in 10.0 section on main branch, but that can be done in the PR that actually deletes them.

=== Deprecations
* The language specific Response Writers have been deprecated in favour of more widely used formats like JSON.
The writer types invoked as part of the `wt` parameter that will be removed in 10 include `python`, `ruby`, `php`, and `phps`.
=======
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you sneak in?

@epugh epugh merged commit 6f5e9d3 into apache:branch_9x Oct 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants