Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4532: Remove KEYS file from git repo and source distribution #329

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

zabetak
Copy link
Member

@zabetak zabetak commented Jan 22, 2024

Projects must publish a KEYS file in their distribution directory which contains all public keys used to sign artifacts (i.e., https://dist.apache.org/repos/dist/release/tez/KEYS).

The KEYS file here is not serving any purpose since it shouldn't be used to verify releases. It adds maintenance overhead (assuming that is kept in sync) and possible confusion to the users with respect to which file they should use to validate the artifacts.

Projects must publish a KEYS file in their distribution directory which contains all public keys used to sign artifacts (i.e., https://dist.apache.org/repos/dist/release/tez/KEYS).

The KEYS file here is not serving any purpose since it shouldn't be used to verify releases. It adds maintenance overhead (assuming that is kept in sync) and possible confusion to the users with respect to which file they should use to validate the artifacts.
@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 25m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 1m 23s The patch does not generate ASF License warnings.
28m 6s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-329/1/artifact/out/Dockerfile
GITHUB PR #329
JIRA Issue TEZ-4532
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux f39abfe0f548 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / d8dda5c
Max. process+thread count 51 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-329/1/console
versions git=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 5e1cdee into apache:master Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants