-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyse go positions #8
base: master
Are you sure you want to change the base?
Conversation
Hey @mathijsclaassen :) I'm trying to test this out, but as soon as I hit "analyze" and it switches over to the Tenuki board, the position disappears. I'm able to edit the blank board, but the existing positions is just gone. I don't see anything showing up in the JS console. I can do some investigation around why On the other hand, the score estimation function is getting a little bit close to outside assistance. I realize that the score estimation isn't particularly accurate, and also that it's easy to export an SGF and do it with an engine anyway, but I want to stay on Richard's good side. I would hate for BiggerGolem to get a reputation (deserved or not) as assisting cheaters. I think I will ask Richard soon about his philosophy on this point. I had some questions in this direction for myself anyway – for example, in chess games, the PGN is unavailable for download until the game is complete, even though for other games like Go, Shogi, and Hex you can download the record at any point (and they will even link to interactive analysis boards from LG itself). I have to assume this was just because strong chess engines were so much easier to cheat with than for those other games, but that reasoning doesn't really apply anymore nowadays. So I will ask Richard what his philosophy is on this type of tool, and see what his response is. In the meantime, I would be happy to merge just the in-line analysis board feature once I can get tenuki to actually load the position :) |
Hi adrian,
I've been using it here all week without problems (though i see room for a
few small improvements). Make sure you disable the original BG extension.
It's not score estimation, it's the counting what it does. You have to
close all the borders and mark dead stones yourself. Perhaps you should ask
about the ethics of this on the forum?
|
Ah, I was trying it in Firefox, where it doesn't work (I will figure out why). I see it does indeed work on Chrome. Is there any way to go back/forward in Analyze mode? If not, we should override the back/forward buttons to fire JS events to control Tenuki when in Analyze mode. As for the scoring, I didn't realize it only scored completed games, since I couldn't get it working until just now 😅 In that case, I assume it is okay, though I will still ask Richard about my related concerns. |
I already overwrite the back button. As far as I know, tenuki doesnt
support forward.
Op 27 sep. 2017 22:41 schreef "Adrian Petrescu" <[email protected]>:
Ah, I was trying it in Firefox, where it doesn't work (I will figure out
why). I see it does indeed work on Chrome.
Is there any way to go back/forward in Analyze mode? If not, we should
override the back/forward buttons to fire JS events to control Tenuki when
in Analyze mode.
As for the scoring, I didn't realize it only scored completed games, since
I couldn't get it working until just now 😅 In that case, I assume it is
okay, though I will still ask Richard about my related concerns.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABzRcbeFweuM1DXRYNvwyIjSGPH9yu9Fks5smrLjgaJpZM4Pg3VY>
.
|
Hi Adrian,
I think nowadays, there are better analyse-experiences for go than Jago. I included the 'tenuki' library (https://github.com/aprescott/tenuki), because it's a relative light library and does all I can think of (at the moment :-). I particularity like its scoring option (it automatically counts when you close the borders and mark the dead stones).
Let me know what you think about this.