-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from ethers v5 to ethers v6 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Jan 30, 2024
Siegrift
changed the title
WIP: Migrate from ethers v5 to ethers v6
Migrate from ethers v5 to ethers v6
Jan 30, 2024
2 tasks
aquarat
reviewed
Feb 5, 2024
aquarat
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 only a very very minor comment around BigInt literals.
This was good for me as I have a better idea now of the differences between ethers v5 and v6 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
Rationale
I followed https://docs.ethers.org/v6/migrating/ and tried to advance by small steps (that's why so many commits). Usually going from file to file, understanding the TS issue and fixing it globally. There were a few gotchas worth mentioning:
when you did
Object.keys(suchResponse)
you got back['0', '1', 'value', 'timestamp']
. In ethers v6, what you get is['0', '1']
(the named keys are not own properties). This breaks utilities such asomit
.Quality assurance
Apart from fixing all of the tests, I ran Airseeker locally for a few hours and it updated the feeds correctly so I think all is fine. I
TODO
ethers.Wallet.fromPhrase
derives the same wallet asethers.Wallet.fromMnemonic
in ethers v5