core: reduce the number of wallet api calls #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In some cases, calls to the wallet API can take a long time (>100ms) so the
library should make as few of them as possible to minimize the time it takes to
connect to a wallet.
Changes in this Pull Request
wallet_requestAccountsused to check if the wallet is locked.addressproperty in theuseAccounthook without waiting for theaccountobject to be fully built.Test Plan
Use the
accountdemo to test that less calls are made to the wallet. You canset a breakpoint in the
InjectedConnector.requestfunction.