New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kakarot invoke returndata and multicall encoding #531

Merged

fracek merged 2 commits into apibara:main from enitrat:fix/kakarot-invoke-returndata-and-multicall-encoding

Nov 1, 2024

Contributor

enitrat commented Nov 1, 2024

Fixes the encoding of multicalls (removes unwanted 0x hex prefixes)
Closes Kakarot's wallet_addInvokeTransaction doesn't return the same data format as Starknet wallets #530 by changing the return type for kakarot's wallet_InvokeTransaction route

enitrat added 2 commits

November 1, 2024 12:21


          fix: kakarot invokeTransaction returndata type & multicall evm encoding

b062bac


          Change files

23f109e

enitrat requested a review from fracek as a code owner

November 1, 2024 05:24

enitrat changed the title ~~fix: invoke returndata and multicall encoding~~ fix: kakarot invoke returndata and multicall encoding

$fracek$

fracek approved these changes

View reviewed changes

$@fracek$

Contributor

fracek commented Nov 1, 2024

Looks good!

$@fracek$ fracek merged commit 45a0c5a into apibara:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet