feat: Upgrade to Crawlee v0.5 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vdusek
commented
Dec 12, 2024
•
vdusek
commented
- service locator
- updates in proxy configuration
vdusek
force-pushed
the
adapt-service-locator
branch
from
7e853dd to
fa871b8
Compare
github-actions
bot
added
t-tooling
vdusek
commented
Dec 12, 2024
janbuchar
reviewed
Dec 12, 2024
3 tasks
vdusek
force-pushed
the
adapt-service-locator
branch
from
12256f3 to
89e28b6
Compare
vdusek
changed the title
vdusek
modified the milestones:
104th sprint - Tooling team,
105th sprint - Tooling team
vdusek
force-pushed
the
adapt-service-locator
branch
from
89e28b6 to
18efd5d
Compare
vdusek
changed the title
vdusek
added
adhoc
vdusek
force-pushed
the
adapt-service-locator
branch
from
18efd5d to
37a1adf
Compare
janbuchar
reviewed
Dec 17, 2024
vdusek
force-pushed
the
adapt-service-locator
branch
2 times, most recently
from
51be03d to
581e5d7
Compare
vdusek
commented
Jan 3, 2025
| from crawlee import service_container | ||
|
|
||
| cast(dict, service_container._services).clear() | ||
| def prepare_test_env(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> Callable[[], None]: |
There was a problem hiding this comment.
prepare_test_env is the same as in the Crawlee
vdusek
commented
Jan 3, 2025
| def _reset_and_patch_default_instances() -> None: | ||
| """Reset the used singletons and patch the default storage client with a temporary directory. | ||
| @pytest.fixture | ||
| def prepare_test_env(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> Callable[[], None]: |
There was a problem hiding this comment.
prepare_test_env is the same as in the Crawlee
vdusek
force-pushed
the
adapt-service-locator
branch
from
581e5d7 to
2c6d513
Compare
This comment was marked as resolved.
This comment was marked as resolved.
janbuchar
reviewed
Jan 8, 2025
janbuchar
reviewed
Jan 8, 2025
janbuchar
approved these changes
Jan 8, 2025
Co-authored-by: Jan Buchar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.