Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix CurlImpersonateHttpClient cookies handler #946

Merged
merged 9 commits into from
Feb 5, 2025
Merged

fix: fix CurlImpersonateHttpClient cookies handler #946

merged 9 commits into from
Feb 5, 2025

Conversation

Mantisus
Copy link
Collaborator

Description

  • fix cookie handling. Behavior alignment with HttpxHttpClient.

Issues

@Mantisus Mantisus requested review from janbuchar and vdusek January 30, 2025 14:18
@janbuchar
Copy link
Collaborator

Could you add a test please?

@Mantisus
Copy link
Collaborator Author

Could you add a test please?

Yeah sure, but I need that PR #947 for these tests 🙂

@Mantisus Mantisus self-assigned this Jan 30, 2025
@Mantisus
Copy link
Collaborator Author

Added tests

vdusek
vdusek approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

src/crawlee/http_clients/_curl_impersonate.py Outdated Show resolved Hide resolved
vdusek
vdusek approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

janbuchar
janbuchar reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some test-related nits, other than that, it looks good

tests/unit/crawlers/_http/test_http_crawler.py Outdated Show resolved Hide resolved
tests/unit/crawlers/_http/test_http_crawler.py Outdated Show resolved Hide resolved
tests/unit/crawlers/_http/test_http_crawler.py Outdated Show resolved Hide resolved
@Mantisus Mantisus requested a review from janbuchar February 4, 2025 10:57
@Mantisus Mantisus requested a review from janbuchar February 4, 2025 15:34
@vdusek vdusek merged commit ed415c4 into apify:master Feb 5, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@janbuchar janbuchar janbuchar approved these changes

Assignees

@Mantisus Mantisus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mantisus @janbuchar @vdusek