Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: graceful BasicCrawler tidy-up on CriticalError #2817

Merged
merged 4 commits into from
Jan 20, 2025
Merged

fix: graceful BasicCrawler tidy-up on CriticalError #2817

merged 4 commits into from
Jan 20, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Jan 20, 2025

Runs all the BasicCrawler clean-up actions even when the AutoscaledPool.run() throws.

Closes #2807

@github-actions github-actions bot added this to the 106th sprint - Tooling team milestone Jan 20, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 20, 2025
@barjin
Copy link
Contributor Author

barjin commented Jan 20, 2025 •
edited
Loading

Since it's not exactly obvious from the diff - this PR only moves the end brace of the finally block all the way till the end of the function (except for the return statement).

@barjin barjin requested review from B4nan and janbuchar and removed request for B4nan January 20, 2025 09:14
@barjin barjin merged commit 53331e8 into master Jan 20, 2025
9 checks passed
@barjin barjin deleted the fix/crawler-cleanup branch January 20, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

@janbuchar janbuchar Awaiting requested review from janbuchar

Assignees

@barjin barjin

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
106th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.

bug: incorrect BasicCrawler clean up after CriticalError
2 participants
@barjin @B4nan