Avoid overriding headers set in onresponse #129
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
fpavageau
force-pushed
the
feature-keep-headers
branch
from
6e09a07
to
cda1999
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
fpavageau
force-pushed
the
feature-keep-headers
branch
from
cda1999
to
46875e7
Compare
fpavageau
force-pushed
the
feature-keep-headers
branch
from
46875e7
to
0e15a62
Compare
Add exception handling to logger when creating a log file. Print logs to console if exeception in creating log file.
Add target hostname in 'transactionContextData' and use that to correctly print target hostname in event logs.
Apply only default plugins if 'request url' is present in global excludeUrls.
Skip the plugins whose excludeUrls includes the 'request url'.
Disable caching if 'disableExcUrlsCache' is set to 'true'.
A sample config is:
plugins:
excludeUrls: '/hello,/hello/'
disableExcUrlsCache: true
sequence:
- oauth ## used for apikey verification #
- json2xml
json2xml:
excludeUrls: '/hello/help'
|
Please push this to for-3.1.6 branch |
Pass emg level configs to plugin's subconfig under key 'emgConfigs'.
Correct the path matcher to block invalid base paths.
Upgrade mocha to 7.0.0 Upgrade lodash to 4.17.19
Remove unused dependency 'helper'
… to close connection when using server sent events
Register the source response close event when target request is sent instead of registering after response is started to stream from target.
Currently, overriding a header from the target response in the source response requires doing it in both ondata_response (when receiving the first chunk of data) and in onend_response (for when the response doesn't contain any data), after verifying that res.headersSent is false. That's clumsy at best. By filtering the copied headers with those already present in the source response, it's possible to set them in onresponse once and for all.
fpavageau
force-pushed
the
feature-keep-headers
branch
from
0e15a62
to
fe57fae
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I have rebased the branch on |
|
The 3.1.6 branch is already scheduled for release. No worries, we will get this sorted out before the next release. |
Currently, overriding a header from the target response in the source
response requires doing it in both
ondata_response(when receiving the firstchunk of data) and in
onend_response(for when the response doesn't containany data), after verifying that
res.headersSentis false. That's clumsy atbest.
By filtering the copied headers with those already present in the source
response, it's possible to set them in
onresponseonce and for all.