Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add unit test #2449

Closed
wants to merge 32 commits into from
Closed

Feature/add unit test #2449

wants to merge 32 commits into from

Conversation

mauriciovieira
Copy link
Contributor

@mauriciovieira mauriciovieira commented Apr 11, 2017 •
edited
Loading

closes #1714

@mauriciovieira
Copy link
Contributor Author

related kadirahq/flow-router#608

@mauriciovieira
Copy link
Contributor Author

and kadirahq/flow-router#668

@marla-singer
Copy link
Contributor

@mauriciovieira I studied the issue comments and as I think can fix it for us. I created the branch that is based on yours. Please test it (PR ##2455)

@mauriciovieira
Copy link
Contributor Author

@marla-singer thank you. I am checking it out.

@mauriciovieira
Copy link
Contributor Author

possible workaround kadirahq/flow-router#615 (but not a solution)

@mauriciovieira mauriciovieira added this to the Sprint 41 milestone Apr 19, 2017
@mauriciovieira mauriciovieira force-pushed the feature/add_unit_test branch 2 times, most recently from 965c899 to 4329102 Compare April 26, 2017 06:40
@brylie brylie self-assigned this Apr 27, 2017
mauriciovieira and others added 16 commits May 2, 2017 19:39
@mauriciovieira
meteor add dispatch:mocha
8b4b1c3
@mauriciovieira
Add npm scripts
453f9b0
@mauriciovieira
meteor add practicalmeteor:chai
f4663dd
@mauriciovieira
Add a dummy test
3fcffa9
@mauriciovieira
Fix dummy test.
d09bc9b
@mauriciovieira
Add npm test scripts
42fa2af
@mauriciovieira
Improve continuous integration
8ae163d 
- Install meteor
- Cache meteor installation
- Run tests
- Run eslint as a pretest step
- Inspired by https://github.com/RocketChat/Rocket.Chat/blob/16743fb2c80f575fd2021d42ac5e31df76db128f/.travis.yml
@mauriciovieira
Wait tests to run for 30 minutes
22387ff
@mauriciovieira
Add chromedriver according to dispatch:mocha docs
64a1f9d
@mauriciovieira
meteor add dispatch:mocha-browser
267b984
@marla-singer @mauriciovieira
Create a new server method userIsAdmin
490d661 
The method checkes if current user has an admin role
@marla-singer @mauriciovieira
Remove part with FlorRouter.wait()
cce9b53 
Check if user is admin usgin the server method
Add route '/users' as "requireAdminRole"
@marla-singer @mauriciovieira
Add route '/users' as "requireAdminRole"
dace893
@mauriciovieira
Import template to fix lint
80dbfed
@mauriciovieira
Revert "Remove part with FlorRouter.wait()"
8f346d3 
This reverts commit e0ae737.
@mauriciovieira
Add copyright header
a8038af
@mauriciovieira
Revert "Create a new server method userIsAdmin"
35e39d2 
This reverts commit 53e85d5.
@mauriciovieira
Format code to improve readability
69cb95c
@mauriciovieira
Wrap FlowRouter initialization in meteor client env
4d2a7c8
@mauriciovieira
Workaround for FlowRouter error
601a9bf 
- [ERROR] There is no route for the path: /
@mauriciovieira
meteor remove tap:i18n-ui
38c6d6e
@mauriciovieira
Revert "Add chromedriver according to dispatch:mocha docs"
272ed48 
This reverts commit a982d14.
@mauriciovieira
Change npm scripts
c40e6b6 
- test-chrome now uses dispatch:mocha-browser
- npm test now only runs test-nightmare
@mauriciovieira
Remove travis caching
d97008c 
- https://travis-ci.org/apinf/platform/builds/223464835 error seems to be cause by current installed packages
- TODO: add caching back after build is OK
@mauriciovieira
meteor add dburles:factory
5b3782c
@mauriciovieira
Add faker npm package as dev-dependency
6fa44f3
@mauriciovieira
Use yarn
2bd4030
@mauriciovieira
Test Branding rendering
240526c
@mauriciovieira
Remove faker
993ac91
@mauriciovieira
meteor add practicalmeteor:mocha
2a58e6d
@mauriciovieira
meteor remove dispatch:mocha-browser
f71d722
@brylie brylie removed their assignment May 5, 2017
@brylie
Copy link
Contributor

brylie commented May 9, 2017

Should we close this PR, since you are working on end-to-end testing in another PR?

@mauriciovieira
Copy link
Contributor Author

@brylie yes.

@mauriciovieira mauriciovieira deleted the feature/add_unit_test branch September 7, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automated Testing testing
Projects
None yet
Milestone
Sprint 41
Development

Successfully merging this pull request may close these issues.

Write one unit test case
3 participants
@mauriciovieira @marla-singer @brylie