Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security | Adding CORS domain restriction based on webwidget url and widget filtering #89

Merged
merged 1 commit into from
May 25, 2023
Merged

Security | Adding CORS domain restriction based on webwidget url and widget filtering #89

merged 1 commit into from
May 25, 2023

Conversation

cmm-apli
Copy link

@cmm-apli cmm-apli commented May 25, 2023 •
edited
Loading

Description

This is required to avoid allowing web plugin to be executed from insecure / unexpected destinations.
#50

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cmm-apli cmm-apli merged commit 3f89111 into develop May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Behtsa Behtsa Behtsa approved these changes

@Arjona99 Arjona99 Awaiting requested review from Arjona99

@AlanDavd AlanDavd Awaiting requested review from AlanDavd

Assignees
No one assigned
Labels
5 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmm-apli @Behtsa