Update Mailer::setLastResponse method

aplus-framework · Feb 8, 2024 · 0d7c94f · 0d7c94f
1 parent 7638a97
commit 0d7c94f
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/Mailer.php b/src/Mailer.php
@@ -151,7 +151,12 @@ public function getConfigs() : array
 
     protected function setLastResponse(?string $lastResponse) : static
     {
-        $this->lastResponse = $lastResponse;
+        if ($lastResponse === null) {
+            $this->lastResponse = null;
+            return $this;
+        }
+        $parts = \explode(\PHP_EOL, $lastResponse);
+        $this->lastResponse = $parts[\array_key_last($parts)];
         return $this;
     }
 

diff --git a/tests/MailerTest.php b/tests/MailerTest.php
@@ -67,6 +67,23 @@ public function testKeepAlive() : void
         self::assertTrue($smtp->send($this->getMessage()));
     }
 
+    public function testLastResponse() : void
+    {
+        $mailer = new class([]) extends Mailer {
+            public function setLastResponse(?string $lastResponse) : static
+            {
+                return parent::setLastResponse($lastResponse);
+            }
+        };
+        self::assertNull($mailer->getLastResponse());
+        $mailer->setLastResponse('250 foo');
+        self::assertSame('250 foo', $mailer->getLastResponse());
+        $mailer->setLastResponse('250 foo' . \PHP_EOL . '250 bar');
+        self::assertSame('250 bar', $mailer->getLastResponse());
+        $mailer->setLastResponse(null);
+        self::assertNull($mailer->getLastResponse());
+    }
+
     public function testFailToAuthenticateUsernameNotSet() : void
     {
         \sleep(5);