Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump deps #7

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore: bump deps #7

merged 1 commit into from
Nov 7, 2023

Conversation

apollo-sturdy
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #7 (ff08f93) into master (0da48cb) will decrease coverage by 0.23%.
The diff coverage is 91.34%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   97.10%   96.87%   -0.23%     
==========================================
  Files          18       18              
  Lines        2732     2788      +56     
==========================================
+ Hits         2653     2701      +48     
- Misses         79       87       +8
Files Coverage Δ
src/helpers.rs 95.23% <100.00%> (ø)
src/lockup.rs 97.14% <100.00%> (ø)
src/msg.rs 78.57% <100.00%> (ø)
src/query.rs 96.45% <100.00%> (+0.10%) ⬆️
src/state.rs 100.00% <ø> (ø)
src/withdraw.rs 93.49% <100.00%> (+0.30%) ⬆️
tests/common/robot.rs 94.25% <100.00%> (+0.08%) ⬆️
tests/test_withdraw.rs 100.00% <100.00%> (ø)
tests/test_zap_base_token.rs 100.00% <100.00%> (ø)
src/contract.rs 93.85% <85.71%> (-0.47%) ⬇️
... and 2 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

pacmanifold
pacmanifold approved these changes Nov 7, 2023
View reviewed changes
tests/test_artifacts/astroport-artifacts/VERSION.md
Comment on lines +1 to +3
These artifacts, except for `astroport_liquidity_manager.wasm`, were downloaded from the Github repository `astroport-core` on the [v2.8.0 release page](https://github.com/astroport-fi/astroport-core/releases/tag/v2.8.0).

`astroport_liquidity_manager.wasm` was downloaded from the Github repository `astroport-core` on the [v3.6.1 release page](https://github.com/astroport-fi/astroport-core/releases/tag/v3.6.1).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:'(

tests/test_withdraw.rs
@@ -352,11 +352,11 @@ fn redeem_both_assets_of_pool(lock_duration: u64) {
vec![
AssetUnchecked::new(
asset1.clone().into(),
asset1_deposit_amount - Uint128::one(),
asset1_deposit_amount - Uint128::one() - Uint128::one(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why an extra minus one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Astroport Liquidity manager does some weird math and one token gets "refunded" to the liquidity helper contract. I didn't feel it was worth it to further refund that token all the way up the chain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/astroport-fi/astroport-core/blob/main/contracts/periphery/liquidity_manager/src/contract.rs#L181

tests/test_withdraw.rs
),
AssetUnchecked::new(
asset2.clone().into(),
asset2_deposit_amount - Uint128::one(),
asset2_deposit_amount - Uint128::one() - Uint128::one(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dito

tests/test_zap_base_token.rs
@@ -253,7 +253,7 @@ fn zap_base_tokens_to_both_assets_of_pool() {
let base_tokens_received = base_token_balance_after_redeem - base_token_balance_before_redeem;

let receive_choice = ReceiveChoice::Underlying;
let max_rel_diff = "0.000000001"; // One unit lost due to rounding
let max_rel_diff = "0.000000001"; // One or two units lost due to rounding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we lose two to rounding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/astroport-fi/astroport-core/blob/main/contracts/periphery/liquidity_manager/src/contract.rs#L181

@apollo-sturdy apollo-sturdy merged commit 837d7d8 into master Nov 7, 2023
10 checks passed
@apollo-sturdy apollo-sturdy deleted the dev/bump-deps branch November 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacmanifold pacmanifold pacmanifold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apollo-sturdy @pacmanifold