fix: Bind socket during constructor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+41
to
+43
| // Since Ktor 3.0.0, "bind" is a suspend function | ||
| // https://youtrack.jetbrains.com/issue/KTOR-7605 | ||
| // We need to call "bind" during the constructor to keep the same behavior as before |
martinbonnin
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
I tested locally with apollographql/apollo-kotlin#6214 and it's all good ✅.
Thanks again for diving into this 🙏 . I'll give it the day to double check everything is good and make a new release tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Discord discussion
After #11, the
serverSocketwas instantiated and bound during the first call of thelistenmethod. However, this creates inconsistency due to concurrency in some tests for developers.The idea is to
bindthe socket during the initialization of the constructor to have the same behavior as before