Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache max age codegen #6132

Closed
wants to merge 2 commits into from
Closed

Cache max age codegen #6132

wants to merge 2 commits into from

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Aug 23, 2024 •
edited
Loading

Related to apollographql/apollo-kotlin-normalized-cache-incubating#52.

  • Adds the cache/0.1 definitions (not merged/still in draft)
  • Codegen creates a Cache object containing a maxAges map according to @cacheControl and @cacheControlField in the schema

@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit e65ded9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66ea990b7f775d0008cb5d1a

@BoD BoD mentioned this pull request Aug 23, 2024
Closed
@BoD BoD force-pushed the cache-max-age-codegen branch from b0adfa1 to e65ded9 Compare September 18, 2024 09:10
@BoD BoD marked this pull request as ready for review September 18, 2024 09:32
@BoD BoD requested a review from martinbonnin as a code owner September 18, 2024 09:32
@BoD
Copy link
Contributor Author

BoD commented Oct 2, 2024

Close in favor of apollographql/apollo-kotlin-normalized-cache-incubating#44

@BoD BoD closed this Oct 2, 2024
@martinbonnin martinbonnin deleted the cache-max-age-codegen branch November 21, 2024 15:18
@martinbonnin martinbonnin restored the cache-max-age-codegen branch November 21, 2024 15:19
@martinbonnin martinbonnin deleted the cache-max-age-codegen branch November 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbonnin martinbonnin Awaiting requested review from martinbonnin martinbonnin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BoD