Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fail-safe mode to disable 2-step introspection and use minimal introspection query #6360

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jan 21, 2025

Should unblock users using problematic servers (e.g. #6327, #6127).

@BoD BoD requested a review from martinbonnin as a code owner January 21, 2025 13:50
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 21, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 34ecdfdc0f772c2eeca6fa5a

Comment on lines 74 to 77
@get:Optional
@get:Input
@get:Option(option = "failSafeIntrospection", description = "if set to true a minimal introspection query is used and no pre-introspection query")
abstract val failSafeIntrospection: Property<Boolean>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about falling back to minimal introspection query if everything else fails?
One less parameter to maintain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Simpler 👍

@BoD BoD merged commit 10910a1 into main Jan 21, 2025
7 checks passed
@BoD BoD deleted the introspection-fail-safe-mode branch January 21, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants