Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: 0.6.0 fails to lex block string comment #632

Closed
lrlna opened this issue Aug 25, 2023 · 2 comments
Closed

parser: 0.6.0 fails to lex block string comment #632

lrlna opened this issue Aug 25, 2023 · 2 comments
Assignees
@goto-bus-stop
Labels
bug Something isn't working

Comments

@lrlna
Copy link
Member

lrlna commented Aug 25, 2023

The following lexed properly in [email protected]:

"""
'/\W/'
"""
type Query {
  a: String
}

But now, on [email protected] produces an error:

errors: ERROR@173:187 "unexpected escaped character" """
'/\W/'
"""

related apollographql/router#3680
@lrlna lrlna added the bug Something isn't working label Aug 25, 2023
@abernix abernix mentioned this issue Aug 25, 2023
Closed
@SimonSapin
Copy link
Contributor

I think this is another case #609

This was referenced Aug 25, 2023
Merged
Merged
@goto-bus-stop
Copy link
Member

Fixed in #638

@goto-bus-stop goto-bus-stop self-assigned this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SimonSapin @goto-bus-stop @lrlna