fix(parser): fix lexing escape sequences in block strings #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
goto-bus-stop
changed the title
goto-bus-stop
commented
Aug 28, 2023
| // sequence. | ||
| if self.eatc('"') { | ||
| self.eatc('"'); | ||
| } |
There was a problem hiding this comment.
There's a test below to make sure """\"""""" is correctly lexed as a block string containing only \""". Previously it would eat too many ".
SimonSapin
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most basic fix for #632, but there are other parse bugs left that may be we should address with a bunch more tests. This fixes a regression in apollo-parser 0.6.0.
Block strings are not meant to support escape sequences in general. But the lexer handled strings and block strings the same way, so an invalid escape sequence in a block string
would cause a lex error. This rips out all the escape sequence handling from block strings except for
\""".I'm running it through the corpus of Apollo schemas right now, about 75% done without problems, so it looks good.