Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Permission Settings Configurable at the Project Level #7

Open
ngranahan opened this issue Mar 12, 2021 · 0 comments
Open

Make Permission Settings Configurable at the Project Level #7

ngranahan opened this issue Mar 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ngranahan
Copy link

The problem to solve

Permission settings are set to 'guest' but could be passed through options, allowing developers to customize in their project-level configuration.

Proposed solution

Describe the solution you'd like

Update lib/guide.js to use options.permission || 'guest' in the canView() function and options.permissionErrorMessage || 'You must be logged in to view this page' in place of the hardcoded error message.

A developer could then define permission and permissionErrorMessage in their project level configuration or use the defaults.
@ngranahan ngranahan added the enhancement New feature or request label Mar 12, 2021
@ngranahan ngranahan mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngranahan