Feature/project level permissions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
LGTM. Tests pass, with Nora's addition of the needed devDependency of course. I did not encounter any of the other mentioned testing problems (eslint related).
@gregvanbrug I'd like you to review and approve and merge though since you know this code best.
gregvanbrug
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #7
Per my conversation with @boutell I added apostrophe as a dev dependency to get tests in
test/pages.jspassing. I still ran into linter errors below when the pre-commit tests ran and bypassed via--no-verify.525252 problems (365695 errors, 159557 warnings) 322750 errors and 159549 warnings potentially fixable with the--fixoption.