Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes admin check when getting all pages #69

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Removes admin check when getting all pages #69

wants to merge 5 commits into from

Conversation

ValJed
Copy link
Contributor

@ValJed ValJed commented May 4, 2021 •
edited
Loading

This is a draft PR, so not opened to review.

@ValJed ValJed self-assigned this May 4, 2021
@ValJed ValJed marked this pull request as draft May 4, 2021 20:53
boutell
boutell requested changes May 4, 2021
View reviewed changes
Copy link
Contributor

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a lot more here than just remove that check. Have you verified this works in node 8? (You can use nvm for that.) node 8 is, unfortunately, still on a lot of A2 servers. We did choose to end Node 6 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boutell boutell boutell requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ValJed ValJed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValJed @boutell