-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#26 Update React Native, use react-native-image-crop-picker #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not fully working yet!
Also updated a couple other dependencies (minor version update)
New collaborators: 174A3B59 Graham iOS <[email protected]>
… into #26_UpdateRN
Also fixes issue #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update!
I've updated all the NPM dependencies to their latest versions as much as possible. Most notably
react-native
to v0.59.In addition I've switched to using
react-native-image-crop-picker
for selecting/taking photos. It contains a lot more functionality thanreact-native-camera
- and fixes issue #38 at the same time (and will be useful when we want to add support for editing the user's profile pic, issue #20).At the moment, iOS does not support free-cropping so I've disabled cropping entirely on iOS at the moment.