-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc for Windows #166
Doc for Windows #166
Conversation
Appium/Dockerfile
Outdated
@@ -150,6 +150,7 @@ ENV APPIUM_DRIVER_ESPRESSO_VERSION="2.29.2" | |||
ENV APPIUM_DRIVER_FLUTTER_VERSION="2.2.2" | |||
ENV APPIUM_DRIVER_GECKO_VERSION="1.2.9" | |||
ENV APPIUM_DRIVER_UIAUTOMATOR2_VERSION="2.34.1" | |||
ENV ANDROID_ADB_SERVER_ADDRESS="host.docker.internal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need to put it inside the Dockerfile, but we can pass the variable on the fly, cant we? as User use different on OS and it seems it is needed only for Windows OS. Maybe you can write it in readme that this environment variable is needed for Windows OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will fix this. Additionally, I will explore more, as currently, it is only confirmed to work with the UIAutomator2 Driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep in dive into the source code, I found that the capability appium:remoteAdbHost
or appium:host
both works.
Take UiAutomator2 driver as example:
The capability was used by uiautomator2Opts.host
the uiautomator2Opts.host
was used by JWProxy
JWProxy
use it to make request to the uiautomator-server running on android.
Espresso driver use the same logic.
Flutter driver directly use UiAutomator2 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @weihongliang233 for the PR
I successfully ran the Docker image on a Windows host and was able to connect to my Android device for development using Appium Inspector. For more detail, please refer to #140 (comment) .