Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for Windows #166

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Doc for Windows #166

merged 3 commits into from
Dec 18, 2023

Conversation

weihongliang233
Copy link
Contributor

I successfully ran the Docker image on a Windows host and was able to connect to my Android device for development using Appium Inspector. For more detail, please refer to #140 (comment) .

Copy link

linux-foundation-easycla bot commented Dec 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@@ -150,6 +150,7 @@ ENV APPIUM_DRIVER_ESPRESSO_VERSION="2.29.2"
ENV APPIUM_DRIVER_FLUTTER_VERSION="2.2.2"
ENV APPIUM_DRIVER_GECKO_VERSION="1.2.9"
ENV APPIUM_DRIVER_UIAUTOMATOR2_VERSION="2.34.1"
ENV ANDROID_ADB_SERVER_ADDRESS="host.docker.internal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need to put it inside the Dockerfile, but we can pass the variable on the fly, cant we? as User use different on OS and it seems it is needed only for Windows OS. Maybe you can write it in readme that this environment variable is needed for Windows OS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will fix this. Additionally, I will explore more, as currently, it is only confirmed to work with the UIAutomator2 Driver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep in dive into the source code, I found that the capability appium:remoteAdbHost or appium:host both works.

Take UiAutomator2 driver as example:

The capability was used by uiautomator2Opts.host

the uiautomator2Opts.host was used by JWProxy

JWProxy use it to make request to the uiautomator-server running on android.

Espresso driver use the same logic.

https://github.com/appium/appium-espresso-driver/blob/3872085e9b8d6056ef655e364754e0488be49f40/lib/driver.js#L512

Flutter driver directly use UiAutomator2 .

https://github.com/appium/appium-flutter-driver/blob/330ab4b9745b36d84c3865c5d171eeb03cc6d558/driver/lib/sessions/android.ts#L9

Copy link
Member

@budtmo budtmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @weihongliang233 for the PR

@budtmo budtmo merged commit 1600b99 into appium:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants