-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libcoro dependency #11433
base: main
Are you sure you want to change the base?
Remove libcoro dependency #11433
Conversation
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just want to make sure windows builds fine.
|
||
set(DEFAULT_COROUTINE_IMPL boost) | ||
if(WIN32) | ||
# boost coroutine not available in windows build environment for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does boost support coroutine on windows now?
The PR title should be "removing libcoro", as we use boost::coroutine2 instead. |
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
# boost coroutine not available in windows build environment for now. | ||
set(DEFAULT_COROUTINE_IMPL libcoro) | ||
elseif(NOT APPLE AND NOT USE_ASAN AND CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "^x86") | ||
# revert to libcoro for x86 linux while we investigate a performance regression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this changed? Is there still a performance regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. not sure what benchmark can show the regression? @xis19 , before merging, let's find the benchmark and compare performance first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would circus work? Or it is already retired?
This is to address #4348
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)