-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli docs and perpetual storage wiggle docs #11482
base: main
Are you sure you want to change the base?
Update cli docs and perpetual storage wiggle docs #11482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jzhou77 do we need to back-port those changes to 7.1/7.3? I'm not sure from which branch the docs are deployed.
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
|
||
Note that to have the Perpetual Storage Wiggle change the storage engine type, you must configure ``storage_migration_type=gradual``. | ||
To enable the Perpetual Storage Wiggle feature, you must configure ``storage_migration_type=gradual perpetual_storage_wiggle=1``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perpetual_storage_wiggle=1
The above command can enable the perpetual storage wiggle feature.
`storage_migration_type=gradual perpetual_storage_wiggle=1. If you want the Perpetual Storage Wiggle change the storage engine type, you must configure also add command
storage_migration_type=gradual``
|
||
Example commands | ||
---------------- | ||
|
||
Open perpetual storage wiggle: ``configure perpetual_storage_wiggle=1``. | ||
Enable perpetual storage wiggle: ``configure storage_migration_type=gradual perpetual_storage_wiggle=1``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need of storage_migration_type=gradual to enable Perpetual storage wiggle
The docs and the feature exists in both 7.1 and 7.3 |
Yes, we need to backport to 7.1 and 7.3 branches. The documentation is generated from release branch, currently 7.1 |
Found some improvements for the docs when I worked on FoundationDB/fdb-kubernetes-operator#2090.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)