ci: Migrate to GitHub Actions and reusable workflows, part three (final) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
changed the title
czechboy0
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following on from #116 and #117, we have now disabled the webhook that was driving the old CI and updated the branch protection rules to require the new GitHub Actions based CI checks.
We can now delete the final shims that were keeping the old CI green, since it is no longer running and complete the migration.
Modifications
Result
Migration complete.
Test Plan
We should be seeing only GitHub Actions checks on this PR and they should all be passing (apart from the ones that are explicitly disabled).